utils.py: remove list_eth_names()#18
Open
nivex wants to merge 1 commit intoDatera:masterfrom
nivex:patch-1
Open
utils.py: remove list_eth_names()#18nivex wants to merge 1 commit intoDatera:masterfrom nivex:patch-1
nivex wants to merge 1 commit intoDatera:masterfrom
nivex:patch-1
Conversation
Removes list_eth_names() function as it appears to only be used by list_eth_ips(). The latter now calls netifaces.interfaces() directly. Fixes #17
This was referenced Nov 28, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes list_eth_names() function as it appears to only be used by list_eth_ips(). The latter now calls netifaces.interfaces() directly. Fixes #17